[SPARK-46397][PYTHON][CONNECT] Function sha2 should raise PySparkValueError for invalid numBits#44529
Closed
zhengruifeng wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-46397][PYTHON][CONNECT] Function sha2 should raise PySparkValueError for invalid numBits#44529zhengruifeng wants to merge 2 commits intoapache:masterfrom
sha2 should raise PySparkValueError for invalid numBits#44529zhengruifeng wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Dec 29, 2023
Contributor
Author
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Function
sha2should raisePySparkValueErrorfor invalidnumBitsWhy are the changes needed?
vanilla PySpark invokes the Scala side and raise an
IllegalArgumentExceptionspark/sql/core/src/main/scala/org/apache/spark/sql/functions.scala
Lines 3212 to 3217 in fa4096e
while Python client won't do this check and raise an
AnalysisException.They should both raise a
PySparkValueErrorfor this case.Does this PR introduce any user-facing change?
yes
How was this patch tested?
added ut
Was this patch authored or co-authored using generative AI tooling?
no